Remove all server mocks from bundle/deploy/dashboard acceptance tests#3048
Merged
Remove all server mocks from bundle/deploy/dashboard acceptance tests#3048
Conversation
…er mimic the Lakeview API
…UUID as a replacement
…tead of UUID as a replacement
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
requested review from
andrewnester,
denik,
pietern and
shreyas-goenka
as code owners
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
approved these changes
Jun 13, 2025
| DASHBOARD_DISPLAY_NAME="test bundle-deploy-dashboard $(uuid)" | ||
| if [ -z "$CLOUD_ENV" ]; then | ||
| DASHBOARD_DISPLAY_NAME="test bundle/deploy/ 6260d50f-e8ff-4905-8f28-812345678903" # use hard-coded uuid when running locally | ||
| export TEST_DEFAULT_WAREHOUSE_ID="warehouse-1234" |
Contributor
There was a problem hiding this comment.
Do we need this, or can this also be removed?
Contributor
|
Great work moving these to the testserver. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is the last in the series of changes for using testserver instead of mocks in acceptance tests for dashboards deployment
Related PRs
Tests
Existing tests